Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FromTim: suggested changes to Collections looking to Python3.8 #9

Closed
wants to merge 44 commits into from

Conversation

wxtim
Copy link

@wxtim wxtim commented Mar 5, 2019

Some possible changes designed to remove future deprecation warnings raised by Pytest when running tests/lib/python/test_diffr.py

oliver-sanders and others added 30 commits March 1, 2019 17:39
* prevent 'Performing next health check' message being output each loop
* adapt to separated identity, description and state_totals endpoints
* remove multi-process logic (replace later with asyncio?)
* separate logic for different output formats
* make output formats orthogonal
* make --describe and --state-totals orthogonal
* make --color and --state-totals orthogonal
* remove back-compat logic
* use colorama for terminal colors, remove TitleFormatter
* interface changes:
    * subtly tweaked colors
    * automatically use color if terminal supports it
    * remove arguments:
        - remove HOSTS argument
    * remove options:
        -a --all (scan all) option
        -b --no-bold option (use --color=never)
        --print-ports
        --old --old-format
    * renamed options:
        -r -raw --raw-format => --format=raw -f raw
        -j --json --json-format => --format=json -f json
    * transformed options:
        --color => --color=WHEN (use the GNU'esque color opt)
* print over multi lines in the log rather than just str.__repr__
* label --- and +++
* the old `cylc graph` with all of the non-textural stuff stripped out
* no longer dependent on gtk or pygraphviz
* interface changes
  --reference           becomes mandatory
  --file, -f            option removed
  --filter              option removed
  --output-file -O      option removed
  --output-format       option removed
* difference lists and dicts
* differences nested structures
* dictionary order does not affect diff, list order does
oliver-sanders and others added 14 commits March 1, 2019 18:02
* tidy .travis.yml
* run unittests under multiple python versions
* add [pycodestyle] section in tox.ini so pycodestyle can be run with no args
* add --ordered option, results are displayed in order, the cost being that slow results will cause blocking
* ensure order of events not affected by race conditions
* cylc scan will clean up contact files, this may have been the culprit
* reduce the time between the kill and the cylc ping to reduce the window for failure
@oliver-sanders oliver-sanders force-pushed the python3 branch 2 times, most recently from ff1ca72 to 2ac9521 Compare March 6, 2019 10:01
@oliver-sanders
Copy link
Owner

oliver-sanders commented Mar 6, 2019

I've cherry-picked this commit onto the python3 branch (roughly equivalent to merging but it saves you rebasing this branch), it will appear on GH when I next push it.

@wxtim wxtim deleted the python3 branch May 27, 2020 08:00
oliver-sanders pushed a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants