forked from cylc/cylc-flow
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FromTim: suggested changes to Collections looking to Python3.8 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prevent 'Performing next health check' message being output each loop
* adapt to separated identity, description and state_totals endpoints * remove multi-process logic (replace later with asyncio?) * separate logic for different output formats * make output formats orthogonal * make --describe and --state-totals orthogonal * make --color and --state-totals orthogonal * remove back-compat logic * use colorama for terminal colors, remove TitleFormatter * interface changes: * subtly tweaked colors * automatically use color if terminal supports it * remove arguments: - remove HOSTS argument * remove options: -a --all (scan all) option -b --no-bold option (use --color=never) --print-ports --old --old-format * renamed options: -r -raw --raw-format => --format=raw -f raw -j --json --json-format => --format=json -f json * transformed options: --color => --color=WHEN (use the GNU'esque color opt)
* print over multi lines in the log rather than just str.__repr__ * label --- and +++
* the old `cylc graph` with all of the non-textural stuff stripped out * no longer dependent on gtk or pygraphviz * interface changes --reference becomes mandatory --file, -f option removed --filter option removed --output-file -O option removed --output-format option removed
* difference lists and dicts * differences nested structures * dictionary order does not affect diff, list order does
* tidy .travis.yml * run unittests under multiple python versions * add [pycodestyle] section in tox.ini so pycodestyle can be run with no args
* add --ordered option, results are displayed in order, the cost being that slow results will cause blocking
* ensure order of events not affected by race conditions
* cylc scan will clean up contact files, this may have been the culprit * reduce the time between the kill and the cylc ping to reduce the window for failure
ff1ca72
to
2ac9521
Compare
I've cherry-picked this commit onto the python3 branch (roughly equivalent to merging but it saves you rebasing this branch), it will appear on GH when I next push it. |
oliver-sanders
pushed a commit
that referenced
this pull request
Jul 23, 2020
Plumbing.fix auth keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some possible changes designed to remove future deprecation warnings raised by Pytest when running
tests/lib/python/test_diffr.py